Optimize nonpayable checks #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2172 +/- ##
==========================================
+ Coverage 84.33% 85.23% +0.90%
==========================================
Files 83 83
Lines 8367 8370 +3
Branches 2019 2021 +2
==========================================
+ Hits 7056 7134 +78
+ Misses 808 733 -75
Partials 503 503
Continue to review full report at Codecov.
|
iamdefinitelyahuman
force-pushed
the
optimize-nonpayable
branch
from
dd2d237 to
198cf36
Compare
fubuloubu
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When a contract contains no payable functions, only perform a single
ASSERT CALLVALUE ISZEROat the beginning of the bytecode instead of at the start of each function.Closes #1776
How I did it
parser.parser::parse_tree_to_lll, prior to parsing the individual functions, check the signature of every function to see if any are payable.parser.function_definitions.parse_external_function::parse_external_function, so the per-function check may be omitted.How to verify it
Run the tests. I added some new test cases to verify that this behavior works as expected.
Cute Animal Picture